PMD Results

The following document contains the results of PMD 7.7.0.

Violations By Priority

Priority 3

com/ibatis/common/beans/BaseProbe.java

Rule Violation Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 100

com/ibatis/common/beans/ClassInfo.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 146148
CollapsibleIfStatements This if statement could be combined with its parent 174177
CollapsibleIfStatements This if statement could be combined with its parent 208214
EmptyCatchBlock Avoid empty catch blocks 305307
EmptyCatchBlock Avoid empty catch blocks 394396

com/ibatis/common/beans/Probe.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPropertyTypeForSetter': the method is declared in an interface type 57
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPropertyTypeForGetter': the method is declared in an interface type 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'hasWritableProperty': the method is declared in an interface type 81
UnnecessaryModifier Unnecessary modifier 'public' on method 'hasReadableProperty': the method is declared in an interface type 93

com/ibatis/common/jdbc/ScriptRunner.java

Rule Violation Line
EmptyControlStatement Empty if statement 217274
EmptyControlStatement Empty if statement 219274
EmptyCatchBlock Avoid empty catch blocks 267269

com/ibatis/common/jdbc/SimpleDataSource.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 588590
EmptyCatchBlock Avoid empty catch blocks 602604
CollapsibleIfStatements This if statement could be combined with its parent 805839
CollapsibleIfStatements This if statement could be combined with its parent 806838
EmptyCatchBlock Avoid empty catch blocks 830832

com/ibatis/common/jdbc/logging/PreparedStatementLogProxy.java

Rule Violation Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 92
PrimitiveWrapperInstantiation Do not use `new Boolean(false)`, prefer `Boolean.FALSE` 94

com/ibatis/common/jdbc/logging/StatementLogProxy.java

Rule Violation Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 76
PrimitiveWrapperInstantiation Do not use `new Boolean(false)`, prefer `Boolean.FALSE` 78

com/ibatis/common/logging/Log.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'debug': the method is declared in an interface type 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'warn': the method is declared in an interface type 62

com/ibatis/common/logging/LogFactory.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 5253
EmptyCatchBlock Avoid empty catch blocks 8485
EmptyCatchBlock Avoid empty catch blocks 99100

com/ibatis/common/logging/nologging/NoLoggingImpl.java

Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'clazz'. 31

com/ibatis/common/resources/Resources.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 333335

com/ibatis/common/util/PaginatedList.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageSize': the method is declared in an interface type 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'isFirstPage': the method is declared in an interface type 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'isMiddlePage': the method is declared in an interface type 47
UnnecessaryModifier Unnecessary modifier 'public' on method 'isLastPage': the method is declared in an interface type 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'isNextPageAvailable': the method is declared in an interface type 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'isPreviousPageAvailable': the method is declared in an interface type 68
UnnecessaryModifier Unnecessary modifier 'public' on method 'nextPage': the method is declared in an interface type 75
UnnecessaryModifier Unnecessary modifier 'public' on method 'previousPage': the method is declared in an interface type 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'gotoPage': the method is declared in an interface type 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageIndex': the method is declared in an interface type 99

com/ibatis/sqlmap/client/SqlMapClient.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'openSession': the method is declared in an interface type 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'openSession': the method is declared in an interface type 169
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSession': the method is declared in an interface type 178
UnnecessaryModifier Unnecessary modifier 'public' on method 'flushDataCache': the method is declared in an interface type 183
UnnecessaryModifier Unnecessary modifier 'public' on method 'flushDataCache': the method is declared in an interface type 192

com/ibatis/sqlmap/client/SqlMapSession.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 31

com/ibatis/sqlmap/client/SqlMapTransactionManager.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTransaction': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTransaction': the method is declared in an interface type 74
UnnecessaryModifier Unnecessary modifier 'public' on method 'commitTransaction': the method is declared in an interface type 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'endTransaction': the method is declared in an interface type 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'setUserConnection': the method is declared in an interface type 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'getUserConnection': the method is declared in an interface type 143
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCurrentConnection': the method is declared in an interface type 154
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDataSource': the method is declared in an interface type 161

com/ibatis/sqlmap/client/extensions/ParameterSetter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setArray': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'setAsciiStream': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBigDecimal': the method is declared in an interface type 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBinaryStream': the method is declared in an interface type 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBlob': the method is declared in an interface type 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBoolean': the method is declared in an interface type 104
UnnecessaryModifier Unnecessary modifier 'public' on method 'setByte': the method is declared in an interface type 115
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBytes': the method is declared in an interface type 126
UnnecessaryModifier Unnecessary modifier 'public' on method 'setCharacterStream': the method is declared in an interface type 139
UnnecessaryModifier Unnecessary modifier 'public' on method 'setClob': the method is declared in an interface type 150
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDate': the method is declared in an interface type 161
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDate': the method is declared in an interface type 174
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDouble': the method is declared in an interface type 185
UnnecessaryModifier Unnecessary modifier 'public' on method 'setFloat': the method is declared in an interface type 196
UnnecessaryModifier Unnecessary modifier 'public' on method 'setInt': the method is declared in an interface type 207
UnnecessaryModifier Unnecessary modifier 'public' on method 'setLong': the method is declared in an interface type 218
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNull': the method is declared in an interface type 229
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNull': the method is declared in an interface type 242
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 253
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 266
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 281
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRef': the method is declared in an interface type 292
UnnecessaryModifier Unnecessary modifier 'public' on method 'setShort': the method is declared in an interface type 303
UnnecessaryModifier Unnecessary modifier 'public' on method 'setString': the method is declared in an interface type 314
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTime': the method is declared in an interface type 325
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTime': the method is declared in an interface type 338
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTimestamp': the method is declared in an interface type 349
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTimestamp': the method is declared in an interface type 362
UnnecessaryModifier Unnecessary modifier 'public' on method 'setURL': the method is declared in an interface type 373
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPreparedStatement': the method is declared in an interface type 380
UnnecessaryModifier Unnecessary modifier 'public' on method 'getParameterIndex': the method is declared in an interface type 387

com/ibatis/sqlmap/client/extensions/ResultGetter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getArray': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBigDecimal': the method is declared in an interface type 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBlob': the method is declared in an interface type 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBoolean': the method is declared in an interface type 73
UnnecessaryModifier Unnecessary modifier 'public' on method 'getByte': the method is declared in an interface type 83
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBytes': the method is declared in an interface type 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'getClob': the method is declared in an interface type 103
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDate': the method is declared in an interface type 113
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDate': the method is declared in an interface type 126
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDouble': the method is declared in an interface type 136
UnnecessaryModifier Unnecessary modifier 'public' on method 'getFloat': the method is declared in an interface type 146
UnnecessaryModifier Unnecessary modifier 'public' on method 'getInt': the method is declared in an interface type 156
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLong': the method is declared in an interface type 166
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 176
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 189
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRef': the method is declared in an interface type 199
UnnecessaryModifier Unnecessary modifier 'public' on method 'getShort': the method is declared in an interface type 209
UnnecessaryModifier Unnecessary modifier 'public' on method 'getString': the method is declared in an interface type 219
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTime': the method is declared in an interface type 229
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTime': the method is declared in an interface type 242
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTimestamp': the method is declared in an interface type 252
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTimestamp': the method is declared in an interface type 265
UnnecessaryModifier Unnecessary modifier 'public' on method 'getURL': the method is declared in an interface type 275
UnnecessaryModifier Unnecessary modifier 'public' on method 'wasNull': the method is declared in an interface type 285
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResultSet': the method is declared in an interface type 292
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnName': the method is declared in an interface type 300
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnIndex': the method is declared in an interface type 308

com/ibatis/sqlmap/client/extensions/TypeHandlerCallback.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setParameter': the method is declared in an interface type 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 98
UnnecessaryModifier Unnecessary modifier 'public' on method 'valueOf': the method is declared in an interface type 117

com/ibatis/sqlmap/engine/accessplan/AccessPlan.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setProperties': the method is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'getProperties': the method is declared in an interface type 41

com/ibatis/sqlmap/engine/builder/xml/SqlMapClasspathEntityResolver.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 102104

com/ibatis/sqlmap/engine/builder/xml/SqlMapParser.java

Rule Violation Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 158
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 161

com/ibatis/sqlmap/engine/builder/xml/XMLSqlSource.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 163165

com/ibatis/sqlmap/engine/cache/CacheController.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'flush': the method is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'removeObject': the method is declared in an interface type 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'putObject': the method is declared in an interface type 67
UnnecessaryModifier Unnecessary modifier 'public' on method 'setProperties': the method is declared in an interface type 75

com/ibatis/sqlmap/engine/cache/fifo/FifoCacheController.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 103105

com/ibatis/sqlmap/engine/cache/lru/LruCacheController.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 103105

com/ibatis/sqlmap/engine/config/ResultMapConfig.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'typeHandlerFactory'. 52
CollapsibleIfStatements This if statement could be combined with its parent 118123

com/ibatis/sqlmap/engine/datasource/DataSourceFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'initialize': the method is declared in an interface type 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDataSource': the method is declared in an interface type 40

com/ibatis/sqlmap/engine/exchange/DataExchange.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'initialize': the method is declared in an interface type 36
UnnecessaryModifier Unnecessary modifier 'public' on method 'getData': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'setData': the method is declared in an interface type 66
UnnecessaryModifier Unnecessary modifier 'public' on method 'setData': the method is declared in an interface type 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCacheKey': the method is declared in an interface type 97

com/ibatis/sqlmap/engine/exchange/DomDataExchange.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 103105

com/ibatis/sqlmap/engine/execution/DefaultSqlExecutor.java

Rule Violation Line
EmptyControlStatement Empty while statement 401402
CollapsibleIfStatements This if statement could be combined with its parent 806812
EmptyCatchBlock Avoid empty catch blocks 809811
EmptyCatchBlock Avoid empty catch blocks 826828
EmptyControlStatement Empty if statement 936942

com/ibatis/sqlmap/engine/execution/SqlExecutor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeUpdate': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'addBatch': the method is declared in an interface type 76
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeBatch': the method is declared in an interface type 90
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeBatchDetailed': the method is declared in an interface type 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeQuery': the method is declared in an interface type 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeUpdateProcedure': the method is declared in an interface type 149
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeQueryProcedure': the method is declared in an interface type 173
UnnecessaryModifier Unnecessary modifier 'public' on method 'cleanup': the method is declared in an interface type 182
UnnecessaryModifier Unnecessary modifier 'public' on method 'init': the method is declared in an interface type 192

com/ibatis/sqlmap/engine/mapping/result/AutoResultMap.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 116118

com/ibatis/sqlmap/engine/mapping/result/ResultMap.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 532537
CollapsibleIfStatements This if statement could be combined with its parent 597599
UnusedFormalParameter Avoid unused method parameters such as 'statementScope'. 798

com/ibatis/sqlmap/engine/mapping/sql/Sql.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSql': the method is declared in an interface type 37
UnnecessaryModifier Unnecessary modifier 'public' on method 'getParameterMap': the method is declared in an interface type 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResultMap': the method is declared in an interface type 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'cleanup': the method is declared in an interface type 69

com/ibatis/sqlmap/engine/mapping/sql/dynamic/DynamicSql.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 216218

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/BaseTagHandler.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 3032
CollapsibleIfStatements This if statement could be combined with its parent 4042
CollapsibleIfStatements This if statement could be combined with its parent 4652

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/ConditionalTagHandler.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 228230

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/DynamicParent.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addChild': the method is declared in an interface type 31

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IterateContext.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 321326

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IterateTagHandler.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 106108

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/SqlTagHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'SKIP_BODY': the field is declared in an interface type 25
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'INCLUDE_BODY': the field is declared in an interface type 28
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'REPEAT_BODY': the field is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'doStartFragment': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'doEndFragment': the method is declared in an interface type 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'doPrepend': the method is declared in an interface type 75

com/ibatis/sqlmap/engine/mapping/statement/ExecuteListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onExecuteStatement': the method is declared in an interface type 32

com/ibatis/sqlmap/engine/mapping/statement/MappedStatement.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'baseCacheKey'. 75

com/ibatis/sqlmap/engine/scope/SessionScope.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 320324
EmptyCatchBlock Avoid empty catch blocks 337339

com/ibatis/sqlmap/engine/transaction/Transaction.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'commit': the method is declared in an interface type 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'rollback': the method is declared in an interface type 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConnection': the method is declared in an interface type 66

com/ibatis/sqlmap/engine/transaction/TransactionManager.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 142145

com/ibatis/sqlmap/engine/transaction/external/ExternalTransaction.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 100102

com/ibatis/sqlmap/engine/transaction/jta/JtaTransaction.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 140152

com/ibatis/sqlmap/engine/type/TypeHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setParameter': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 73
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'valueOf': the method is declared in an interface type 98
UnnecessaryModifier Unnecessary modifier 'public' on method 'equals': the method is declared in an interface type 110

Priority 4

com/ibatis/common/jdbc/SimpleDataSource.java

Rule Violation Line
UselessParentheses Useless parentheses. 549
UselessParentheses Useless parentheses. 1098

com/ibatis/common/resources/Resources.java

Rule Violation Line
ExtendsObject No need to explicitly extend Object. 30

com/ibatis/sqlmap/engine/builder/xml/SqlMapConfigParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 173
UselessParentheses Useless parentheses. 177
UselessParentheses Useless parentheses. 181182
UselessParentheses Useless parentheses. 186
UselessParentheses Useless parentheses. 190
UselessParentheses Useless parentheses. 194

com/ibatis/sqlmap/engine/cache/CacheModel.java

Rule Violation Line
UselessParentheses Useless parentheses. 295
UselessParentheses Useless parentheses. 378

com/ibatis/sqlmap/engine/config/MappedStatementConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 215

com/ibatis/sqlmap/engine/config/SqlMapConfiguration.java

Rule Violation Line
UnnecessaryImport Unused import 'java.util.Map' 47
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file 429

com/ibatis/sqlmap/engine/exchange/ListDataExchange.java

Rule Violation Line
UselessParentheses Useless parentheses. 85
UselessParentheses Useless parentheses. 99
UselessParentheses Useless parentheses. 112

com/ibatis/sqlmap/engine/execution/DefaultSqlExecutor.java

Rule Violation Line
UselessParentheses Useless parentheses. 381
UselessParentheses Useless parentheses. 583
UselessParentheses Useless parentheses. 620
UselessParentheses Useless parentheses. 706
UselessParentheses Useless parentheses. 735
UselessParentheses Useless parentheses. 762
UselessParentheses Useless parentheses. 788

com/ibatis/sqlmap/engine/mapping/result/AutoResultMap.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Locale' is already in scope because it is imported in this file 102
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Locale' is already in scope because it is imported in this file 109
UselessParentheses Useless parentheses. 124

com/ibatis/sqlmap/engine/mapping/result/loader/ResultLoader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang.reflect': 'Array' is already in scope because it is imported in this file 119

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/BaseTagHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 25
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 34

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/ConditionalTagHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 63
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'SKIP_BODY' is already in scope because it is inherited by an enclosing type 65

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/DynamicTagHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BaseTagHandler': 'SqlTagHandler::INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsGreaterEqualTagHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsGreaterThanTagHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsLessEqualTagHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsLessThanTagHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 26

com/ibatis/sqlmap/engine/mapping/statement/PaginatedDataList.java

Rule Violation Line
UselessParentheses Useless parentheses. 191

com/ibatis/sqlmap/engine/type/BigDecimalTypeHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 30
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.math': 'BigDecimal' is already in scope because it is imported in this file 61

com/ibatis/sqlmap/engine/type/BlobTypeHandlerCallback.java

Rule Violation Line
UselessParentheses Useless parentheses. 47

com/ibatis/sqlmap/engine/type/DateOnlyTypeHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 41
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 50
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 59

com/ibatis/sqlmap/engine/type/DateTypeHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 41
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 50
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 59

com/ibatis/sqlmap/engine/type/StringTypeHandler.java

Rule Violation Line
UselessParentheses Useless parentheses. 29

com/ibatis/sqlmap/engine/type/TimeOnlyTypeHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 41
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 50
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 59

Files

com/ibatis/common/beans/BaseProbe.java

Rule Violation Priority Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 3 100

com/ibatis/common/beans/ClassInfo.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 146148
CollapsibleIfStatements This if statement could be combined with its parent 3 174177
CollapsibleIfStatements This if statement could be combined with its parent 3 208214
EmptyCatchBlock Avoid empty catch blocks 3 305307
EmptyCatchBlock Avoid empty catch blocks 3 394396

com/ibatis/common/beans/Probe.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 3 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPropertyTypeForSetter': the method is declared in an interface type 3 57
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPropertyTypeForGetter': the method is declared in an interface type 3 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'hasWritableProperty': the method is declared in an interface type 3 81
UnnecessaryModifier Unnecessary modifier 'public' on method 'hasReadableProperty': the method is declared in an interface type 3 93

com/ibatis/common/jdbc/ScriptRunner.java

Rule Violation Priority Line
EmptyControlStatement Empty if statement 3 217274
EmptyControlStatement Empty if statement 3 219274
EmptyCatchBlock Avoid empty catch blocks 3 267269

com/ibatis/common/jdbc/SimpleDataSource.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 549
EmptyCatchBlock Avoid empty catch blocks 3 588590
EmptyCatchBlock Avoid empty catch blocks 3 602604
CollapsibleIfStatements This if statement could be combined with its parent 3 805839
CollapsibleIfStatements This if statement could be combined with its parent 3 806838
EmptyCatchBlock Avoid empty catch blocks 3 830832
UselessParentheses Useless parentheses. 4 1098

com/ibatis/common/jdbc/logging/PreparedStatementLogProxy.java

Rule Violation Priority Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 3 92
PrimitiveWrapperInstantiation Do not use `new Boolean(false)`, prefer `Boolean.FALSE` 3 94

com/ibatis/common/jdbc/logging/StatementLogProxy.java

Rule Violation Priority Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 3 76
PrimitiveWrapperInstantiation Do not use `new Boolean(false)`, prefer `Boolean.FALSE` 3 78

com/ibatis/common/logging/Log.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'debug': the method is declared in an interface type 3 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'warn': the method is declared in an interface type 3 62

com/ibatis/common/logging/LogFactory.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 5253
EmptyCatchBlock Avoid empty catch blocks 3 8485
EmptyCatchBlock Avoid empty catch blocks 3 99100

com/ibatis/common/logging/nologging/NoLoggingImpl.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'clazz'. 3 31

com/ibatis/common/resources/Resources.java

Rule Violation Priority Line
ExtendsObject No need to explicitly extend Object. 4 30
EmptyCatchBlock Avoid empty catch blocks 3 333335

com/ibatis/common/util/PaginatedList.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageSize': the method is declared in an interface type 3 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'isFirstPage': the method is declared in an interface type 3 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'isMiddlePage': the method is declared in an interface type 3 47
UnnecessaryModifier Unnecessary modifier 'public' on method 'isLastPage': the method is declared in an interface type 3 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'isNextPageAvailable': the method is declared in an interface type 3 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'isPreviousPageAvailable': the method is declared in an interface type 3 68
UnnecessaryModifier Unnecessary modifier 'public' on method 'nextPage': the method is declared in an interface type 3 75
UnnecessaryModifier Unnecessary modifier 'public' on method 'previousPage': the method is declared in an interface type 3 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'gotoPage': the method is declared in an interface type 3 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageIndex': the method is declared in an interface type 3 99

com/ibatis/sqlmap/client/SqlMapClient.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'openSession': the method is declared in an interface type 3 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'openSession': the method is declared in an interface type 3 169
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSession': the method is declared in an interface type 3 178
UnnecessaryModifier Unnecessary modifier 'public' on method 'flushDataCache': the method is declared in an interface type 3 183
UnnecessaryModifier Unnecessary modifier 'public' on method 'flushDataCache': the method is declared in an interface type 3 192

com/ibatis/sqlmap/client/SqlMapSession.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 3 31

com/ibatis/sqlmap/client/SqlMapTransactionManager.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTransaction': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTransaction': the method is declared in an interface type 3 74
UnnecessaryModifier Unnecessary modifier 'public' on method 'commitTransaction': the method is declared in an interface type 3 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'endTransaction': the method is declared in an interface type 3 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'setUserConnection': the method is declared in an interface type 3 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'getUserConnection': the method is declared in an interface type 3 143
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCurrentConnection': the method is declared in an interface type 3 154
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDataSource': the method is declared in an interface type 3 161

com/ibatis/sqlmap/client/extensions/ParameterSetter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setArray': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'setAsciiStream': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBigDecimal': the method is declared in an interface type 3 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBinaryStream': the method is declared in an interface type 3 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBlob': the method is declared in an interface type 3 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBoolean': the method is declared in an interface type 3 104
UnnecessaryModifier Unnecessary modifier 'public' on method 'setByte': the method is declared in an interface type 3 115
UnnecessaryModifier Unnecessary modifier 'public' on method 'setBytes': the method is declared in an interface type 3 126
UnnecessaryModifier Unnecessary modifier 'public' on method 'setCharacterStream': the method is declared in an interface type 3 139
UnnecessaryModifier Unnecessary modifier 'public' on method 'setClob': the method is declared in an interface type 3 150
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDate': the method is declared in an interface type 3 161
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDate': the method is declared in an interface type 3 174
UnnecessaryModifier Unnecessary modifier 'public' on method 'setDouble': the method is declared in an interface type 3 185
UnnecessaryModifier Unnecessary modifier 'public' on method 'setFloat': the method is declared in an interface type 3 196
UnnecessaryModifier Unnecessary modifier 'public' on method 'setInt': the method is declared in an interface type 3 207
UnnecessaryModifier Unnecessary modifier 'public' on method 'setLong': the method is declared in an interface type 3 218
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNull': the method is declared in an interface type 3 229
UnnecessaryModifier Unnecessary modifier 'public' on method 'setNull': the method is declared in an interface type 3 242
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 3 253
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 3 266
UnnecessaryModifier Unnecessary modifier 'public' on method 'setObject': the method is declared in an interface type 3 281
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRef': the method is declared in an interface type 3 292
UnnecessaryModifier Unnecessary modifier 'public' on method 'setShort': the method is declared in an interface type 3 303
UnnecessaryModifier Unnecessary modifier 'public' on method 'setString': the method is declared in an interface type 3 314
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTime': the method is declared in an interface type 3 325
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTime': the method is declared in an interface type 3 338
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTimestamp': the method is declared in an interface type 3 349
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTimestamp': the method is declared in an interface type 3 362
UnnecessaryModifier Unnecessary modifier 'public' on method 'setURL': the method is declared in an interface type 3 373
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPreparedStatement': the method is declared in an interface type 3 380
UnnecessaryModifier Unnecessary modifier 'public' on method 'getParameterIndex': the method is declared in an interface type 3 387

com/ibatis/sqlmap/client/extensions/ResultGetter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getArray': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBigDecimal': the method is declared in an interface type 3 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBlob': the method is declared in an interface type 3 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBoolean': the method is declared in an interface type 3 73
UnnecessaryModifier Unnecessary modifier 'public' on method 'getByte': the method is declared in an interface type 3 83
UnnecessaryModifier Unnecessary modifier 'public' on method 'getBytes': the method is declared in an interface type 3 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'getClob': the method is declared in an interface type 3 103
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDate': the method is declared in an interface type 3 113
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDate': the method is declared in an interface type 3 126
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDouble': the method is declared in an interface type 3 136
UnnecessaryModifier Unnecessary modifier 'public' on method 'getFloat': the method is declared in an interface type 3 146
UnnecessaryModifier Unnecessary modifier 'public' on method 'getInt': the method is declared in an interface type 3 156
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLong': the method is declared in an interface type 3 166
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 3 176
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 3 189
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRef': the method is declared in an interface type 3 199
UnnecessaryModifier Unnecessary modifier 'public' on method 'getShort': the method is declared in an interface type 3 209
UnnecessaryModifier Unnecessary modifier 'public' on method 'getString': the method is declared in an interface type 3 219
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTime': the method is declared in an interface type 3 229
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTime': the method is declared in an interface type 3 242
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTimestamp': the method is declared in an interface type 3 252
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTimestamp': the method is declared in an interface type 3 265
UnnecessaryModifier Unnecessary modifier 'public' on method 'getURL': the method is declared in an interface type 3 275
UnnecessaryModifier Unnecessary modifier 'public' on method 'wasNull': the method is declared in an interface type 3 285
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResultSet': the method is declared in an interface type 3 292
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnName': the method is declared in an interface type 3 300
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnIndex': the method is declared in an interface type 3 308

com/ibatis/sqlmap/client/extensions/TypeHandlerCallback.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setParameter': the method is declared in an interface type 3 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 3 98
UnnecessaryModifier Unnecessary modifier 'public' on method 'valueOf': the method is declared in an interface type 3 117

com/ibatis/sqlmap/engine/accessplan/AccessPlan.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setProperties': the method is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'getProperties': the method is declared in an interface type 3 41

com/ibatis/sqlmap/engine/builder/xml/SqlMapClasspathEntityResolver.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 102104

com/ibatis/sqlmap/engine/builder/xml/SqlMapConfigParser.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 173
UselessParentheses Useless parentheses. 4 177
UselessParentheses Useless parentheses. 4 181182
UselessParentheses Useless parentheses. 4 186
UselessParentheses Useless parentheses. 4 190
UselessParentheses Useless parentheses. 4 194

com/ibatis/sqlmap/engine/builder/xml/SqlMapParser.java

Rule Violation Priority Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 3 158
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 3 161

com/ibatis/sqlmap/engine/builder/xml/XMLSqlSource.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 163165

com/ibatis/sqlmap/engine/cache/CacheController.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'flush': the method is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'getObject': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'removeObject': the method is declared in an interface type 3 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'putObject': the method is declared in an interface type 3 67
UnnecessaryModifier Unnecessary modifier 'public' on method 'setProperties': the method is declared in an interface type 3 75

com/ibatis/sqlmap/engine/cache/CacheModel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 295
UselessParentheses Useless parentheses. 4 378

com/ibatis/sqlmap/engine/cache/fifo/FifoCacheController.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 103105

com/ibatis/sqlmap/engine/cache/lru/LruCacheController.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 103105

com/ibatis/sqlmap/engine/config/MappedStatementConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 215

com/ibatis/sqlmap/engine/config/ResultMapConfig.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'typeHandlerFactory'. 3 52
CollapsibleIfStatements This if statement could be combined with its parent 3 118123

com/ibatis/sqlmap/engine/config/SqlMapConfiguration.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'java.util.Map' 4 47
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Map' is already in scope because it is imported in this file 4 429

com/ibatis/sqlmap/engine/datasource/DataSourceFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'initialize': the method is declared in an interface type 3 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDataSource': the method is declared in an interface type 3 40

com/ibatis/sqlmap/engine/exchange/DataExchange.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'initialize': the method is declared in an interface type 3 36
UnnecessaryModifier Unnecessary modifier 'public' on method 'getData': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'setData': the method is declared in an interface type 3 66
UnnecessaryModifier Unnecessary modifier 'public' on method 'setData': the method is declared in an interface type 3 82
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCacheKey': the method is declared in an interface type 3 97

com/ibatis/sqlmap/engine/exchange/DomDataExchange.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 103105

com/ibatis/sqlmap/engine/exchange/ListDataExchange.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 85
UselessParentheses Useless parentheses. 4 99
UselessParentheses Useless parentheses. 4 112

com/ibatis/sqlmap/engine/execution/DefaultSqlExecutor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 381
EmptyControlStatement Empty while statement 3 401402
UselessParentheses Useless parentheses. 4 583
UselessParentheses Useless parentheses. 4 620
UselessParentheses Useless parentheses. 4 706
UselessParentheses Useless parentheses. 4 735
UselessParentheses Useless parentheses. 4 762
UselessParentheses Useless parentheses. 4 788
CollapsibleIfStatements This if statement could be combined with its parent 3 806812
EmptyCatchBlock Avoid empty catch blocks 3 809811
EmptyCatchBlock Avoid empty catch blocks 3 826828
EmptyControlStatement Empty if statement 3 936942

com/ibatis/sqlmap/engine/execution/SqlExecutor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeUpdate': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'addBatch': the method is declared in an interface type 3 76
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeBatch': the method is declared in an interface type 3 90
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeBatchDetailed': the method is declared in an interface type 3 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeQuery': the method is declared in an interface type 3 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeUpdateProcedure': the method is declared in an interface type 3 149
UnnecessaryModifier Unnecessary modifier 'public' on method 'executeQueryProcedure': the method is declared in an interface type 3 173
UnnecessaryModifier Unnecessary modifier 'public' on method 'cleanup': the method is declared in an interface type 3 182
UnnecessaryModifier Unnecessary modifier 'public' on method 'init': the method is declared in an interface type 3 192

com/ibatis/sqlmap/engine/mapping/result/AutoResultMap.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Locale' is already in scope because it is imported in this file 4 102
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Locale' is already in scope because it is imported in this file 4 109
EmptyCatchBlock Avoid empty catch blocks 3 116118
UselessParentheses Useless parentheses. 4 124

com/ibatis/sqlmap/engine/mapping/result/ResultMap.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 532537
CollapsibleIfStatements This if statement could be combined with its parent 3 597599
UnusedFormalParameter Avoid unused method parameters such as 'statementScope'. 3 798

com/ibatis/sqlmap/engine/mapping/result/loader/ResultLoader.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang.reflect': 'Array' is already in scope because it is imported in this file 4 119

com/ibatis/sqlmap/engine/mapping/sql/Sql.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSql': the method is declared in an interface type 3 37
UnnecessaryModifier Unnecessary modifier 'public' on method 'getParameterMap': the method is declared in an interface type 3 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResultMap': the method is declared in an interface type 3 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'cleanup': the method is declared in an interface type 3 69

com/ibatis/sqlmap/engine/mapping/sql/dynamic/DynamicSql.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 216218

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/BaseTagHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 4 25
CollapsibleIfStatements This if statement could be combined with its parent 3 3032
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 4 34
CollapsibleIfStatements This if statement could be combined with its parent 3 4042
CollapsibleIfStatements This if statement could be combined with its parent 3 4652

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/ConditionalTagHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 4 63
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlTagHandler': 'SKIP_BODY' is already in scope because it is inherited by an enclosing type 4 65
CollapsibleIfStatements This if statement could be combined with its parent 3 228230

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/DynamicParent.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'addChild': the method is declared in an interface type 3 31

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/DynamicTagHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BaseTagHandler': 'SqlTagHandler::INCLUDE_BODY' is already in scope because it is inherited by an enclosing type 4 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsGreaterEqualTagHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 4 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsGreaterThanTagHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 4 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsLessEqualTagHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 4 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IsLessThanTagHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ConditionalTagHandler': 'NOT_COMPARABLE' is already in scope because it is inherited by an enclosing type 4 26

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IterateContext.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 321326

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/IterateTagHandler.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 106108

com/ibatis/sqlmap/engine/mapping/sql/dynamic/elements/SqlTagHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'SKIP_BODY': the field is declared in an interface type 3 25
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'INCLUDE_BODY': the field is declared in an interface type 3 28
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'REPEAT_BODY': the field is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'doStartFragment': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'doEndFragment': the method is declared in an interface type 3 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'doPrepend': the method is declared in an interface type 3 75

com/ibatis/sqlmap/engine/mapping/statement/ExecuteListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'onExecuteStatement': the method is declared in an interface type 3 32

com/ibatis/sqlmap/engine/mapping/statement/MappedStatement.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'baseCacheKey'. 3 75

com/ibatis/sqlmap/engine/mapping/statement/PaginatedDataList.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 191

com/ibatis/sqlmap/engine/scope/SessionScope.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 320324
EmptyCatchBlock Avoid empty catch blocks 3 337339

com/ibatis/sqlmap/engine/transaction/Transaction.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'commit': the method is declared in an interface type 3 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'rollback': the method is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 3 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConnection': the method is declared in an interface type 3 66

com/ibatis/sqlmap/engine/transaction/TransactionManager.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 142145

com/ibatis/sqlmap/engine/transaction/external/ExternalTransaction.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 100102

com/ibatis/sqlmap/engine/transaction/jta/JtaTransaction.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 140152

com/ibatis/sqlmap/engine/type/BigDecimalTypeHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 30
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.math': 'BigDecimal' is already in scope because it is imported in this file 4 61

com/ibatis/sqlmap/engine/type/BlobTypeHandlerCallback.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 47

com/ibatis/sqlmap/engine/type/DateOnlyTypeHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 41
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 50
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 59

com/ibatis/sqlmap/engine/type/DateTypeHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 41
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 50
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 59

com/ibatis/sqlmap/engine/type/StringTypeHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 29

com/ibatis/sqlmap/engine/type/TimeOnlyTypeHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 41
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 50
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'Date' is already in scope because it is imported in this file 4 59

com/ibatis/sqlmap/engine/type/TypeHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setParameter': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 3 73
UnnecessaryModifier Unnecessary modifier 'public' on method 'getResult': the method is declared in an interface type 3 88
UnnecessaryModifier Unnecessary modifier 'public' on method 'valueOf': the method is declared in an interface type 3 98
UnnecessaryModifier Unnecessary modifier 'public' on method 'equals': the method is declared in an interface type 3 110